Updates for the upcoming new Insights outputs#4
Merged
Conversation
Member
There was a problem hiding this comment.
Do we need these empty constructors for anything (also in the Email class)?
Contributor
Author
There was a problem hiding this comment.
I was mostly cutting and pasting here. Can I just move the @JsonProperty to the attribute declaration instead?
Member
There was a problem hiding this comment.
I'd leave it on the constructor parameter.
…er than having a BLANK enum
Member
There was a problem hiding this comment.
These are private. You should probably rephrase this in terms of the getter. Same with the warning attributes.
Jackson does the right thing here and turns a JSON value with a UUID into a UUID object for us.
oschwald
added a commit
that referenced
this pull request
Jan 21, 2016
Updates for the upcoming new Insights outputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.