fix(player): keep foreground service alive across track swaps - #10
Open
Dollarius wants to merge 1 commit into
Open
fix(player): keep foreground service alive across track swaps#10Dollarius wants to merge 1 commit into
Dollarius wants to merge 1 commit into
Conversation
Track swaps in loadAndPlayTrackInternal exposed the promoted precached player to MediaSession with playWhenReady=false before play() was called. Media3 samples that as user disengagement and arms its user-engaged foreground-service timeout; the timer is never cancelled, so the service is demoted 10 minutes later while music is still playing. Android then stops the idle service, cuts the app's network, and playback starves at the next track boundary. Apply settings and start the new player before swapping the delegate, so the session never observes a paused player mid-transition. Also trust the actual player state in SimpleMediaService.onUpdateNotification and keep the service in the foreground whenever it is really playing, which self-heals any stale demotion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes music randomly stopping between tracks after a few songs on Android (maxrave-dev/SimpMusic#2233), the cause that remained after the audio-focus fix from maxrave-dev/SimpMusic#2022.
During a track swap,
loadAndPlayTrackInternallet MediaSession observe the promoted precached player withplayWhenReady=falsebeforeplay()ran. Media3 samples that as user disengagement and arms its 10-minute foreground-service timeout, which never gets cancelled: the service is demoted mid-playback, Android stops it as idle, cuts the app's network, and playback starves at the next track (evidence in the issue).loadAndPlayTrackInternal: start the new player beforeswapDelegate()/notifyMediaItemChanged()(the crossfade path already does this).SimpleMediaService.onUpdateNotification: keep the service in the foreground while the player is actually playing, self-healing any wrong demotion.Tested on a Galaxy S23 (Android 16): 1h+ of background playback across 14 track changes with
isForeground=truethroughout, where 1.5.1 stopped within ~15 minutes.Fixes maxrave-dev/SimpMusic#2233