Feat/desktop mpv backend

[maxrave-dev]

No description provided.

[Copilot]

Pull request overview

This PR replaces the desktop (JVM) VLC/vlcj media backend with an mpv (libmpv via JNA) backend, including a software-rendered video surface and updated DI/UI wiring to use the new player implementation.

Changes:

• Introduces a libmpv JNA binding (MpvLibrary) and a handle wrapper (MpvPlayer) with an event-pump thread and mpv option/property management.
• Adds a Swing JPanel software-render surface (MpvVideoSurfacePanel) using mpv’s SW render API and integrates it into playback.
• Switches desktop DI and UI from VlcPlayerAdapter to MpvPlayerAdapter, removes vlcj dependencies, and updates module loaders accordingly.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
media/media-jvm/src/main/java/com/simpmusic/media_jvm/mpv/MpvVideoSurfacePanel.kt	New Swing panel implementing mpv SW rendering into a BufferedImage.
media/media-jvm/src/main/java/com/simpmusic/media_jvm/mpv/MpvPlayerAdapter.kt	Ports the previous adapter logic to mpv and adds DJ/AutoMix crossfade behavior.
media/media-jvm/src/main/java/com/simpmusic/media_jvm/mpv/MpvPlayer.kt	New libmpv handle wrapper (options, event pump, playback control, audio filter chain).
media/media-jvm/src/main/java/com/simpmusic/media_jvm/mpv/MpvLibrary.kt	New JNA bindings for libmpv + helpers (render params, EDL URL building, locale handling).
media/media-jvm/src/main/java/com/simpmusic/media_jvm/di/DesktopPlayerModule.kt	Switches the injected desktop backend to MpvPlayerAdapter and renames the loader function.
media/media-jvm/build.gradle.kts	Removes vlcj dependency and adds JNA dependency for libmpv binding.
media/media-jvm-ui/src/main/java/com/maxrave/media_jvm_ui/ui/MediaPlayerView.kt	Updates UI to construct/use MpvPlayer and collects the mpv video surface component.
media/media-jvm-ui/build.gradle.kts	Removes vlcj dependency from the UI module.
domain/src/commonMain/kotlin/com/maxrave/domain/mediaservice/player/MediaPlayerListener.kt	Updates a comment to remove VLC-specific wording.
data/src/jvmMain/kotlin/com/maxrave/data/di/loader/Loader.jvm.kt	Updates loader call from loadVlcModule() to loadDesktopPlayerModule().
media/media-jvm/src/main/java/com/simpmusic/media_jvm/MacOsVlcDiscoverer.kt	Removes VLC macOS native discovery strategy (backend no longer uses vlcj).
media/media-jvm/src/main/java/com/simpmusic/media_jvm/DefaultVlcDiscoverer.kt	Removes VLC Windows/Linux native discovery strategy (backend no longer uses vlcj).

Comments suppressed due to low confidence (1)

media/media-jvm/src/main/java/com/simpmusic/media_jvm/mpv/MpvPlayerAdapter.kt:1724

• outgoingPlayer is nullable (val outgoingPlayer = currentPlayer), but this block calls outgoingPlayer.setRate(...) and outgoingPlayer.setPitchScale(...) without a null-check. This will not compile and can also race if currentPlayer changes during a crossfade. Wrap the updates in a let (or otherwise make outgoingPlayer non-null) before calling these methods.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.