🛡️ Sentinel: [CRITICAL] Fix out of bounds memory read in NATA TX path

[maxugly]

🚨 Severity: CRITICAL
💡 Vulnerability: Out-of-bounds memory read in sim_tx_packet via non-linear sk_buff structures. The function copied packet payloads using memcpy(..., skb->data, skb->len). If an sk_buff is non-linear, skb->data points only to the linear header portion, causing memcpy to read past the buffer boundary, potentially leaking sensitive kernel memory.
🎯 Impact: Kernel memory disclosure or local denial-of-service (panic) via crafted, fragmented packets or network stack conditions producing non-linear sk_buffs.
🔧 Fix: Replaced memcpy with skb_copy_bits to safely copy payload data, properly abstracting the sk_buff geometry. Returns -EFAULT on copy failure to abort gracefully.
✅ Verification: Changes pass code review and adhere to project DOX requirements. Re-verified implementation locally in code.

---

PR created automatically by Jules for task 4478448984510796569 started by @maxugly

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@maxugly, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e00d57e-6e0b-4297-ae31-6ea35f50f7e0

📥 Commits

Reviewing files that changed from the base of the PR and between 6d5b3ed and f2eac42.

📒 Files selected for processing (2)

• .jules/sentinel.md
• module/nata_blk.c

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}