🛡️ Sentinel: [CRITICAL] Fix out-of-bounds read with nonlinear sk_buffs

[maxugly]

🚨 Severity: CRITICAL
💡 Vulnerability: The TX path (sim_tx_packet) incorrectly assumed sk_buff data buffers are strictly contiguous and used memcpy over skb->len. This leads to out-of-bounds memory reads (potential kernel panic or sensitive data leak) when processing non-linear (fragmented) sk_buff packets.
🎯 Impact: An attacker could trigger a kernel panic (Denial of Service) or potentially disclose sensitive kernel memory contents across the bridge interface by sending large, fragmented network packets.
🔧 Fix: Replaced memcpy with skb_copy_bits, which correctly traverses the sk_buff fragment list and safely copies all packet data, regardless of linearity. If the copy fails, it safely aborts and returns -EFAULT.
✅ Verification: Code statically verified. Tests require a non-sandbox environment with kernel headers, but the change structurally eliminates the out-of-bounds read risk.

---

PR created automatically by Jules for task 11701681845010285203 started by @maxugly

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@maxugly, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5bcc8f74-ddcd-40fc-b24c-5ac16db0f473

📥 Commits

Reviewing files that changed from the base of the PR and between 6d5b3ed and 4bba493.

📒 Files selected for processing (2)

• .jules/sentinel.md
• module/nata_blk.c

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}