Extract lib/testing/log, refactor lib/log and lib/bats/assertions
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also moves `test-go` from `lib/testing/log` to `lib/testing/environment`, as it may prove generally useful.
The updates to `lib/format` from #107 make this function much shorter. Also, the logic to check the file descriptors was sort of confused and not really doing anything, at least not anything helpful, since the decision to print or strip formatting codes is now made per log level file descriptor in `@go.log`.
Seems a little easier to understand the message format this way, and using `%b` in the `printf -v` statement seems less subtle than using it in the `printf` that actually generates the output.
It occurred to me that `@go.log_command` should not try to only convert unexpanded formatting code sequences if they exist in the output, but should strip them out entirely whether they're expanded or not.
This also precipitated a refactor of `assert_log_equals` and its implementation functions to handle the expanded code, which actually simplified the logic a bit. By the same token, it's no longer required that `format_log_label` be called before other `lib/log` functions, as `__GO_LOG_LEVELS_FORMATTED` will always contain expanded format codes and `@go.log` will strip them out if need be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40. Future PRs may add to or tweak the
lib/batsandlib/testingmodules, but the existing functions are now completely exported and tested.In addition to extracting the
lib/testing/logmodule, this PR contains simplifications tolib/logand replacesechowithprintfin several places.