Small improvements, add @go.test_compgen, make cmd-desc/from-file test faster
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should've been part of #155.
This is in anticipation of adding a `--test` option to the forthcoming `./go new` test file generator.
Regarding the claim that this new function is faster than the old hand-written loops, here are representative timings for the command: TEST_FILTER='(directories|: tab completion$)' gos test complete get/ For hand-written loops: 43 tests, 0 failures, 39 skipped real 0m7.020s user 0m3.352s sys 0m3.473s For `@go.test_compgen`: 43 tests, 0 failures, 39 skipped real 0m6.367s user 0m3.071s sys 0m3.104s Considering the fact that most of that time was spent skipping 39 tests, the result is pretty substantial. Even beyond that, it provided the insight that led to filing issue #156.
The reason this test suite was so slow before was because the test cases made direct calls to the functions under test instead of wrapping them inside `TEST_GO_SCRIPT`. The functions would then call other functions, then call other functions in loops, and so on, causing Bats to do a lot of work building stack traces with every call. A sample time before this change on my macOS MacBoook Pro: 6 tests, 0 failures real 0m6.554s user 0m2.820s sys 0m3.487s A sample time after: 6 tests, 0 failures real 0m2.316s user 0m1.010s sys 0m1.204s I expect the difference to be even more dramatic on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was all done during the course of preparing an implementation of
./go newto address #142. Of particular note:.gitignoreencouraging the use of$HOME/.config/git/ignore@go.test_compgentolib/testing/environmentlib/bats/functionfromlib/bats/assertions#156command-descriptions/from-filetestSee the commit messages for details and timing examples.