docs(hash): SMHASHER3.md leads with current state; add same-rig comparison table - #226
Merged
Conversation
The document led with the obsolete initial verdict (147/188) and buried the post-hardening re-run; skimmers read the wrong result. Now: current state (five remaining core-round failures) first, initial run kept as history.
Fab-Cat
approved these changes
Jul 4, 2026
helly25
added a commit
that referenced
this pull request
Jul 4, 2026
# Conflicts: # CHANGELOG.md # mbo/digest/BUILD.bazel # mbo/digest/digest.h # mbo/digest/digest_test.cc # mbo/hash/hash_internal_util.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redoes
mbo/hash/SMHASHER3.mdas a pure current-state document — the historical narrative (initial 147/188 run, hardening chronology) is gone; a status doc, not a chronicle.Same-rig comparison table — all six variants measured by us under identical conditions (same SMHasher3 build @
6ab4343, container, flags, machine); no quoting of upstream results:rapidhashmhxxh64xxh3mhxxh3Notable:
Seed*batteries.rapidhashis the only clean pass, making the 64-bit default rationale self-evident from data;mh(WIP) places above the xxHash family.xxh3stays the 128-bit default as the only canonical-value 128-bit format in the library.mh's native 128-bit variant exposes lane correlation that the 64-bit fold hides; analyzed in the doc and added to the "mh is WIP" TODO item (lane decorrelation).The doc keeps: results table + interpretation, mh's failure analysis (core-round diffusion + 128-bit lane correlation, TODO pointers), and a reproduction-grade methodology section.