refactor!: remove obsolete crate features - #608
Merged
Conversation
Remove the non-functional derive feature and empty default feature declarations. The narrow crate now has no dependencies, and CI exercises its single feature-independent configuration.
mbrobbel
enabled auto-merge (squash)
July 22, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
derivefeature andnarrow-derivedependency fromnarrowBreaking change
narrowno longer defines aderiveCargo feature. The feature compiled an empty proc-macro crate but did not re-export or enable any API.The
narrow-deriveandnarrow-ffipackages remain workspace members. A future derive feature can be introduced when it has a concrete macro re-export; FFI remains a separate integration crate to avoid a cyclic dependency.CI impact
The Miri job previously ran the same test suite twice for 33 seconds per feature mode. It now runs once. The redundant MSRV feature-mode check is also removed.
Validation
narrowcargo check --workspace --all-targetscargo test --workspace --all-targets(98 tests)cargo test --workspace --doc(100 doctests)cargo clippy --workspace --all-targets -- -Dwarningscargo fmt --all -- --checkcargo llvm-cov --workspace --all-targets --codecov(98 tests and report generation)