Skip to content

refactor!: remove obsolete crate features - #608

Merged
mbrobbel merged 3 commits into
mainfrom
featureless-core
Jul 22, 2026
Merged

refactor!: remove obsolete crate features#608
mbrobbel merged 3 commits into
mainfrom
featureless-core

Conversation

@mbrobbel

Copy link
Copy Markdown
Owner

Summary

  • remove the non-functional derive feature and narrow-derive dependency from narrow
  • remove empty default feature declarations from all workspace crates
  • make the existing README-based crate documentation unconditional
  • collapse CI onto one feature-independent build, test, Miri, and coverage configuration

Breaking change

narrow no longer defines a derive Cargo feature. The feature compiled an empty proc-macro crate but did not re-export or enable any API.

The narrow-derive and narrow-ffi packages remain workspace members. A future derive feature can be introduced when it has a concrete macro re-export; FFI remains a separate integration crate to avoid a cyclic dependency.

CI impact

The Miri job previously ran the same test suite twice for 33 seconds per feature mode. It now runs once. The redundant MSRV feature-mode check is also removed.

Validation

  • Cargo metadata reports empty feature maps for all three packages and no dependencies for narrow
  • cargo check --workspace --all-targets
  • cargo test --workspace --all-targets (98 tests)
  • cargo test --workspace --doc (100 doctests)
  • cargo clippy --workspace --all-targets -- -Dwarnings
  • cargo fmt --all -- --check
  • cargo llvm-cov --workspace --all-targets --codecov (98 tests and report generation)

mbrobbel added 2 commits July 22, 2026 15:37
Remove the non-functional derive feature and empty default feature declarations. The narrow crate now has no dependencies, and CI exercises its single feature-independent configuration.
@mbrobbel
mbrobbel enabled auto-merge (squash) July 22, 2026 13:40
@mbrobbel
mbrobbel merged commit e8ef999 into main Jul 22, 2026
6 checks passed
@mbrobbel
mbrobbel deleted the featureless-core branch July 22, 2026 13:42
@narrow-app narrow-app Bot mentioned this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant