Disable auto backup pause on crossplay enabled server #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do to a recent observation in mbround18#1050, the behavior of AUTO_BACKUP_PAUSE_WITH_NO_PLAYERS should be additionally negated when cross play is enabled, as the Steam Query port also doesn't return player counts properly in this situation. This can be later removed when there is a more concrete method implemented for querying player counts.
Owner
|
Hey @Stealthii excellent addition! running it thru the checks now :) |
mbround18
added
docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior of AUTO_BACKUP_PAUSE_WITH_NO_PLAYERS should be additionally negated when cross play is enabled, as the Steam Query port also doesn't return player counts properly in this situation.
This can be later removed when there is a more concrete method implemented for querying player counts.
Fixes #1050.
Contributions
Checklist