Skip to content

chore: Remove explicit stop overrides #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaddox5 merged 2 commits into from
Apr 16, 2025
Merged

chore: Remove explicit stop overrides #873

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abcf778
Update explicit stops for Boat-F6 & F7.
cmaddox5 Apr 15, 2025
a6729b3
Try removing overrides instead of creating new ones.
cmaddox5 Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions apps/state/lib/state/stops_on_route.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,27 +179,9 @@ defmodule State.StopsOnRoute do
end)
|> Enum.flat_map(&do_gather_direction_group(route, global_stop_id_order, &1))

explicit_override_records = gather_explicit_overrides(route, direction_id)

shape_records
|> Enum.concat(other_records)
|> Enum.concat(explicit_override_records)
Enum.concat(shape_records, other_records)
end

defp gather_explicit_overrides(%{id: "Boat-F6"}, 1),
do: [
{"Boat-F6", 1, :all, "Boat-F6-Wdy-Smr-23", true,
["Boat-Winthrop", "Boat-Quincy", "Boat-Logan", "Boat-Fan", "Boat-Aquarium"]}
]

defp gather_explicit_overrides(%{id: "Boat-F6"}, 0),
do: [
{"Boat-F6", 0, :all, "Boat-F6-Wdy-Smr-23", true,
["Boat-Aquarium", "Boat-Fan", "Boat-Logan", "Boat-Quincy", "Boat-Winthrop"]}
]

defp gather_explicit_overrides(_, _), do: []

defp do_gather_direction_group(route, global_order, {group_key, trip_group}) do
{canonical?, shape_id, service_id, direction_id} = group_key

Expand Down
Loading