-
Notifications
You must be signed in to change notification settings - Fork 20
chore: Bump phoenix_live_view from 0.20.7 to 1.1.14 #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adefd14 to
9f3248b
Compare
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
527892b to
12e07bf
Compare
|
Dependabot can't resolve your Elixir dependency files. Because of this, Dependabot cannot update this pull request. |
12e07bf to
2280f63
Compare
970de8c to
85e81cf
Compare
|
I made changes to make this work and the autoassigner isn't working so tagging you @rudiejd 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review note: I'm not 100% certain about these changes, I was mainly going off of errors and not entirely sure what this should be configured as, so more scrutiny here would be best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine. looking at the deprecation notice in the changelog, you can set the format to an empty list if you don't know the format ahead of time. But it seems like this controller macro is only used for defining HTML controls and not JSON (as opposed to the api_controller macro), so it seems like we know that the format will only be HTML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it seems like this controller macro is only used for defining HTML controls and not JSON
I wish it were this clear cut 😭
https://github.com/mbta/api/blob/master/apps/api_web/lib/api_web/controllers/status_controller.ex
Maybe we should do that distinction though, I tried converting status_controller to use :api_controller but it ended up requiring implementation of functions that it didn't have by default, and didn't seem to apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, good catch!
|
A newer version of phoenix_live_view exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [phoenix_live_view](https://github.com/phoenixframework/phoenix_live_view) from 0.20.7 to 1.1.14. - [Changelog](https://github.com/phoenixframework/phoenix_live_view/blob/v1.1.14/CHANGELOG.md) - [Commits](phoenixframework/phoenix_live_view@v0.20.7...v1.1.14) --- updated-dependencies: - dependency-name: phoenix_live_view dependency-version: 1.1.14 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
85e81cf to
cf253df
Compare
|
The changes look good to me. I will deploy this to an environment and poke around in the web controllers before approving. It's interesting to me that we even need the live view dependency for API - I thought the web pages we have were mostly static and not interactive. |
Bumps phoenix_live_view from 0.20.7 to 1.1.14.
Changelog
Sourced from phoenix_live_view's changelog.
... (truncated)
Commits
f54b8e6release v1.1.14bd408cfUpdate assetsa740830properly append portal elements in form recovery7d0b11apass phx-target for portal casea99a135Only set empty title for main view (#4013)aea69b9fix require warning in test66b5f79Upgrade :esbuild to minimum version when upgrading to 1.1 (#4011)e2c7610remove unused requires66a1177Enable :handle_event hooks to reply from LiveComponents (#4006)324ba18Recover teleported forms (#4009)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)