Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 13, 2025

Bumps phoenix_live_view from 0.20.7 to 1.1.14.

Changelog

Sourced from phoenix_live_view's changelog.

v1.1.14 (2025-10-07)

Bug fixes

  • Fix form recovery not working when form is teleported (#4009)
  • Fix handle_event hook not being able to return {:halt, reply, socket} in LiveComponents (#4006)
  • Only set title to default when it is set to empty by the main view, not by nested or sticky views (#4003)

Enhancements

  • Automatically update esbuild version when using Igniter upgrader from 1.0 to 1.1 (#4011)
  • Fix unused require warnings on Elixir 1.19

v1.1.13 (2025-09-18)

Bug fixes

  • Fix invalid stream merging in LiveViewTest (#3993)
  • Fix extra spaces when formatting nested inline tags (#3995)
  • Ensure error reasons are serialized into message on the client (#3984)
  • Prevent JavaScript exception when passing "*" to JS.ignore_attributes/3 (#3996)

v1.1.12 (2025-09-14)

Bug fixes

  • Prevent HEEx line from being reported as uncovered when using a pattern in :let={} (#3989)

Enhancements

  • Automatically symlink assets/node_modules folder for colocated hooks (see the documentation for Phoenix.LiveView.ColocatedJS, #3988)

v1.1.11 (2025-09-04)

Bug fixes

  • Fix LiveComponents being destroyed when their DOM ID changes, even though they are still rendered (#3981)
  • Fix warning when an empty comprehension is rendered in LiveViewTest

Enhancements

  • Speed up duplicate ID check in LiveViewTest (#3962)

v1.1.10 (2025-09-03)

Bug fixxes

  • Regression in v1.1.9 - fix Phoenix.LiveViewTest.submit_form/2 and Phoenix.LiveViewTest.follow_trigger_action/2 crashing when using keywords lists and not properly handling atom keys (#3975)

v1.1.9 (2025-09-02)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Oct 13, 2025
@dependabot dependabot bot requested a review from a team as a code owner October 13, 2025 13:33
@dependabot dependabot bot removed the request for review from a team October 13, 2025 13:33
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 13, 2025
@dependabot dependabot bot requested a review from firestack October 13, 2025 13:33
@dependabot dependabot bot added the elixir Pull requests that update Elixir code label Oct 13, 2025
@dependabot dependabot bot force-pushed the dependabot/hex/phoenix_live_view-1.1.14 branch 4 times, most recently from adefd14 to 9f3248b Compare October 15, 2025 18:04
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2025

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot recreate.

@dependabot dependabot bot force-pushed the dependabot/hex/phoenix_live_view-1.1.14 branch 4 times, most recently from 527892b to 12e07bf Compare October 20, 2025 19:41
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 21, 2025

Dependabot can't resolve your Elixir dependency files. Because of this, Dependabot cannot update this pull request.

@dependabot dependabot bot force-pushed the dependabot/hex/phoenix_live_view-1.1.14 branch from 12e07bf to 2280f63 Compare October 21, 2025 15:46
@firestack firestack force-pushed the dependabot/hex/phoenix_live_view-1.1.14 branch 3 times, most recently from 970de8c to 85e81cf Compare October 21, 2025 19:17
@firestack firestack requested review from a team and rudiejd October 21, 2025 19:32
@firestack
Copy link
Member

I made changes to make this work and the autoassigner isn't working so tagging you @rudiejd 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review note: I'm not 100% certain about these changes, I was mainly going off of errors and not entirely sure what this should be configured as, so more scrutiny here would be best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. looking at the deprecation notice in the changelog, you can set the format to an empty list if you don't know the format ahead of time. But it seems like this controller macro is only used for defining HTML controls and not JSON (as opposed to the api_controller macro), so it seems like we know that the format will only be HTML

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it seems like this controller macro is only used for defining HTML controls and not JSON

I wish it were this clear cut 😭
https://github.com/mbta/api/blob/master/apps/api_web/lib/api_web/controllers/status_controller.ex

Maybe we should do that distinction though, I tried converting status_controller to use :api_controller but it ended up requiring implementation of functions that it didn't have by default, and didn't seem to apply.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good catch!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 22, 2025

A newer version of phoenix_live_view exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot bot and others added 3 commits October 22, 2025 10:50
Bumps [phoenix_live_view](https://github.com/phoenixframework/phoenix_live_view) from 0.20.7 to 1.1.14.
- [Changelog](https://github.com/phoenixframework/phoenix_live_view/blob/v1.1.14/CHANGELOG.md)
- [Commits](phoenixframework/phoenix_live_view@v0.20.7...v1.1.14)

---
updated-dependencies:
- dependency-name: phoenix_live_view
  dependency-version: 1.1.14
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@firestack firestack force-pushed the dependabot/hex/phoenix_live_view-1.1.14 branch from 85e81cf to cf253df Compare October 22, 2025 14:50
@rudiejd
Copy link
Member

rudiejd commented Oct 23, 2025

The changes look good to me. I will deploy this to an environment and poke around in the web controllers before approving. It's interesting to me that we even need the live view dependency for API - I thought the web pages we have were mostly static and not interactive.

@firestack firestack merged commit 051d501 into master Oct 23, 2025
31 checks passed
@firestack firestack deleted the dependabot/hex/phoenix_live_view-1.1.14 branch October 23, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants