fix(SF2.0): Strange line-wrap on Safari#3060
Merged
joshlarson merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
Author
|
The failed smoke test is unrelated to this change, and is (hopefully) addressed in: |
jlucytan
requested changes
Mar 31, 2026
Contributor
jlucytan
left a comment
jlucytan
left a comment
There was a problem hiding this comment.
question(blocking?): I actually don't see the +1 on initial load, is this expected? It only appears after I've changed schedules to something else and back.
Happy to approve PR if we want to address that in a different ticket.
jlucytan
approved these changes
Mar 31, 2026
Contributor
jlucytan
left a comment
jlucytan
left a comment
There was a problem hiding this comment.
per discussion in roundtable, opening the missing +1 as a separate ticket. line-wrap lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 📅🔎 Funky line-wrapping on Safari
Implementation
class="no-wrap"Screenshots
(prod on the left; dev-green on the right)
How to test
Visit a subway departures page in Safari (can't be when running locally, because Safari and locally-running LiveView don't get along, which is why this is deployed to dev-green).