Skip to content

fix(SF2.0): Have next-day +1 show up on the last day of the month#3068

Merged
joshlarson merged 3 commits intomainfrom
jdl/sf2.0/fix-plus-one-on-last-day-of-month
Apr 3, 2026
Merged

fix(SF2.0): Have next-day +1 show up on the last day of the month#3068
joshlarson merged 3 commits intomainfrom
jdl/sf2.0/fix-plus-one-on-last-day-of-month

Conversation

@joshlarson
Copy link
Copy Markdown
Contributor

Scope

No ticket, but noticed while reviewing a different PR (thanks for catching this @jlucytan!)

Implementation

  • The joys of Date.after?/2

Screenshots

Screenshot 2026-03-31 at 1 51 30 PM

How to test

If you're looking at this on the last day of the month (which happens to be today, as of opening this PR), then take a look at the daily schedule section for any subway page.

I'm not sure of a good way to test this on not-the-last-day-of-the-month.

@joshlarson joshlarson requested a review from a team as a code owner March 31, 2026 17:57
@joshlarson joshlarson requested a review from lvachon1 March 31, 2026 17:57
@joshlarson joshlarson enabled auto-merge (squash) April 3, 2026 12:16
@joshlarson joshlarson merged commit 0e0cf42 into main Apr 3, 2026
17 checks passed
@joshlarson joshlarson deleted the jdl/sf2.0/fix-plus-one-on-last-day-of-month branch April 3, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants