Skip to content

chore: Manual dependency updates (part 1) - #970

Merged
KaylaBrady merged 6 commits into
mainfrom
kb-deps-updates
May 9, 2025
Merged

chore: Manual dependency updates (part 1)#970
KaylaBrady merged 6 commits into
mainfrom
kb-deps-updates

Conversation

@KaylaBrady

Copy link
Copy Markdown
Collaborator

Summary

Ticket: Manual dependency updates

What is this PR for?
This PR covers the first chunk of manual upgrades:

  • iOS dependencies are updated
  • mapbox for android is updated
  • pre-commit autoupdate is run
  • Spotless is updated & new formatting applied

The new spotless formatting touches a lot of files. Breaking off here before doing the AGP / Gradle / Kotlin upgrades.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible (ideally in shared code)

Testing

What testing have you done?

  • Ran ios & android locally to confirm both still run as expected

"revision" : "1997fb3c3dc0d8181690a1ec192ed907bcead9e8",
"version" : "3.0.0"
"revision" : "bf840e6b9529d105687840fe2c9dcd74197d46d1",
"version" : "4.0.0"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a bunch of linker errors after this turf upgrade. Clearing DerivedData, cleaning the build folder, and re-building resolved.

Comment on lines +162 to +163
"revision" : "25a4d8a3fa754ef3fb587a34addd08c7e568abc4",
"version" : "5.3.5"

@KaylaBrady KaylaBrady May 9, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was pinned a branch of SwiftPhoenixClient with my changes to address some socket race conditions on backgrounding. I didn't follow-through on that PR, but the core of the changes were added in 5.3.4 davidstump/SwiftPhoenixClient@a21c465, so we can get back to using the regular release

Comment thread buildSrc/build.gradle.kts
`kotlin-dsl`
kotlin("plugin.serialization") version "1.9.22"
id("com.diffplug.spotless").version("6.21.0")
id("com.diffplug.spotless").version("7.0.3")

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I could tell using the alias wasn't possible here, but if there is a way lmk!

Comment thread shared/build.gradle.kts
throw IllegalStateException(
"${file.path}:${line.index + 1}:${column + 1} calls getValue"
)
object : Serializable, FormatterFunc.NeedsFile {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround for a known issue introduced in the latest version of spotless diffplug/spotless#2387 (comment)

@KaylaBrady
KaylaBrady marked this pull request as ready for review May 9, 2025 13:59
@KaylaBrady
KaylaBrady requested a review from a team as a code owner May 9, 2025 13:59
@KaylaBrady
KaylaBrady requested a review from BrandonTR May 9, 2025 13:59
@KaylaBrady
KaylaBrady added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 2057a57 May 9, 2025
@KaylaBrady
KaylaBrady deleted the kb-deps-updates branch May 9, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants