Disable sending feedback on per widget basis

[enbyted]

This was originally suggested here: http://www.qlcplus.org/forum/viewtopic.php?f=24&t=10158&p=46291#p46273

I would see it like this:
In any VCwidget that sends feedback could have a "send feedback" checkbox under "custom feedback". This checkbox is bound to a flag that basically disables updateFeedback execution. This checkbox is selected by default and affects specific VCwidget, so someone might have a button and slider bound to the same button on console and have the slider not mess custom feedback data up.

It seems to be trivial to implement and might me useful for someone.
If nobody points any major drawback in it and nobody picks this up I'll work on it on next weekend and file a pull request.

[enbyted]

Okay, so after some looking around the code it seems that the easiest approach would be:

• Add a "send feedback" checkbox to InputSelectionWidget (or something along these lines)
• Modify every single widget that uses InputSelectionWidget to support disabling feedback on particular channel.
• Probably implement it with backwards compatibility - enabling this checkbox by calling a special method. Just like it's done for custom feedback values.

It's trivial to implement, but still a lot of work for very small feature. I can work on it, but is it really that useful that it's worth the time?

Other, much simpler approaches:

1. Implementing feedback disable widget global, for example a flag that would disable sendFeedback functions. Then adding a global checkbox for each widget type.
2. Implementing feedback disable only for basic widgets - buttons (originally requested) and faders (might be useful).

Any opinions on this one?

[siegmund42]

What the user requested was disabling for a widget, so I think alternative no.1 is not the way to go (I can't even imagine a use case for that).

The basic questions are:
Would @mcallegari merge it in the way you described?
And are you willing to do it?
Let's answer these before proceeding. I personally have no use case for this feature, but if some users would be happy with it, its fine.

While writing I had an idea about placing the checkbox: It could be hidden by the "custom feedback" button and placed at the beginning of the line that appears when clicking it.

[enbyted]

Yes, as I stated originally I would be willing to do that.
However the original idea looks like a lot of work for very rare use case, that's why I'm holding back and would like some discussion first - I don't have unlimited time, why waste it?

Small clarification for no.1 - by global I've meant per each individual widget instance, for example if we take a vcspeeddial there would be a checkbox that disables all feedbacks for this specific vcspeeddial.

Still I don't like no.1, just see it as an option.
Original approach seems to me like the way to go (your suggestion about checkbox placement sounds good to me), but it's a fair amount of work.
No.2 would be trivial and fast to implement and would address most of use cases when you actually need to disable feedback (more complex ones could be solved using loopback then).