feat(state): emit sketch.attached event in Store.AttachSketch#6
Merged
Conversation
Close the state-sync audit gap: attaching a sketch mutated the spec state without leaving an activity-log entry. Store.AttachSketch now records a sketch.attached event, so the board's activity trace and standup reflect the attach like every other domain action (state-sync-discipline). - AttachSketch takes an actor and appends the sketch.attached event. - cmd/vector/sketch.go passes resolveActor() to the new signature. Note: cmd/vector/sketch.go here is the pre-cobra (runSpecAttachSketch) form. The separate adopt-cobra-lipgloss-cli PR migrates cmd/vector to a cobra tree; when both land, keep newSpecAttachSketchCmd (cobra) with the 4-arg AttachSketch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes a state-sync audit gap: attaching a sketch mutated spec state without leaving an activity-log entry.
Store.AttachSketchnow records asketch.attachedevent, so the board's activity trace and standup reflect the attach like every other domain action (state-sync-discipline).AttachSketchtakes anactorand appends thesketch.attachedevent (SketchAttachedData{Name}).EvtSketchAttached = "sketch.attached".cmd/vector/sketch.gopassesresolveActor()to the new signature.Gate
gofmtclean ·go vet ./...·go build ./...·go test ./...green.Provenance / merge note
This change was sitting uncommitted in the working tree alongside the cobra migration; it is split out here as its own PR.
cmd/vector/sketch.gohere is the pre-cobra (runSpecAttachSketch) form. The separate #5 (adopt-cobra-lipgloss-cli) migratescmd/vectorto a cobra tree. When both land, resolve thesketch.goconflict by keepingnewSpecAttachSketchCmd(cobra) with the 4-argAttachSketch.🤖 Generated with Claude Code