-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): bump react-dom and @types/react-dom #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
81c5a4c to
d210407
Compare
|
@dependabot rebase |
|
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
d210407 to
1bbc4da
Compare
|
@dependabot recreate |
d62ece8 to
808c1eb
Compare
|
@dependabot rebase |
a257808 to
962dd38
Compare
|
@dependabot rebase |
756b49b to
1003524
Compare
|
@dependabot rebase |
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.2.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.0/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
1003524 to
46f2c58
Compare
This commit fixes the peer dependency conflict introduced by the Dependabot update. The update upgraded react-dom to v19.2.0 and @types/react-dom to v19.2.3, but left react and @types/react at v18. The @types/react-dom@19.2.3 package requires @types/react@^19.2.0 as a peer dependency, which was causing npm install to fail. Changes: - Upgraded react from ^18.3.0 to ^19.2.0 - Upgraded @types/react from ^18.3.0 to ^19.2.0 - Regenerated package-lock.json Fixes failing status checks for PR #5 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PR Review: React 19.2.0 UpgradeSummaryThis PR upgrades React and React DOM from 18.3.x to 19.2.0, along with the corresponding TypeScript type definitions. This is a major version upgrade that introduces significant changes and new features. ✅ Positive Observations
|
- Add Zod validation for Jellyfin credentials (Critical #2) - Sanitize and validate email inputs for account linking (Critical #3) - Replace console.log with centralized logger (Important #5) - Replace type assertions with Zod runtime validation (Minor #9) - Enhance error handling in Jellyfin sign-in (Important #4) All critical and important issues from code review have been addressed. Tests passing, linting clean.
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.2.0Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
8618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)8bb7241Bump useEffectEvent to Canary (#34610)83c88adHandle fabric root level fragment with compareDocumentPosition (#34533)68f00c9Release Activity in Canary (#34374)3168e08[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)3434ff4Add scrollIntoView to fragment instances (#32814)Updates
@types/react-domfrom 18.3.7 to 19.2.3Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)