Fixes *WS node previews#1438
Merged
Merged
Conversation
Member
|
This is the wrong approach, the file should not be touching the temp directory at least for images. Comfy's seminative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C# changes are necessary because comfy will only preview a video if it's saved to the tmp directory first... and I found that comfy lists that preview file in its history and swarm reads and pulls it in so the video ends up added twice.
So we teach swarm to ignore the history entry from any node that already sent its data over the websocket, and only care about the WS data when both are present.
Includes video support:
There is a small bug where if you gen an image first, then switch to a video model within swarmui and click Import From Generate Tab on the same tab, the previous image remains: