Skip to content

[REMS-296] Questionnaire package#47

Merged
plarocque4 merged 6 commits intodevfrom
questionnaire-package
Jan 26, 2023
Merged

[REMS-296] Questionnaire package#47
plarocque4 merged 6 commits intodevfrom
questionnaire-package

Conversation

@KeeyanGhoreshi
Copy link
Copy Markdown
Contributor

@KeeyanGhoreshi KeeyanGhoreshi commented Jan 25, 2023

Describe your changes

These changes add the questionnaire package operation to the REMS Admin FHIR server, which allows DTR to actually complete its interaction when going through the whole workflow. A VSAC API key is required to operate, however, as the ValueSets must be queried.

Support for the $questionnaire-package operation involves processing the questionnaires to find sub-questionnaires, the CQL supporting those sub-questionnaires, and value sets supporting that CQL, then compiling all the resources into a bundle to be sent back. Questionnaires are processed at the time they are requested by the operation.

NOTE: this entire process of gathering valuesets will have to change in relation to the VSAC caching task #46

To use this, you must first set VSAC_KEY environment variable (or through env.json) as your key. I would also recommend resetting/deleting your database so that it refills with the new resources available through the CDS-Library folder which is now embedded in the REMS admin.

You can test the changes by running the entire environment, going through the request generator, and opening DTR. It should successfully open a questionnaire, as it receives the parameters it is expecting from the package operation.

NOTE: Currently some of the questions do not get prepopulated. This is because the elm conversion fails to find supporting libraries at conversion time, so the cql errors out when using dependent libraries. This will have to be fixed but it is not an effect of the package operation

Issue ticket number and Jira link

REMS-296

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Base automatically changed from fhir-server to dev January 25, 2023 20:10
Comment thread src/config.ts
plarocque4
plarocque4 previously approved these changes Jan 25, 2023
Copy link
Copy Markdown
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks clean and includes everything that the old CRD did. I tested it manually with Postman and the returned bundle included everything that I expected it to.

@plarocque4 plarocque4 merged commit 7325ea1 into dev Jan 26, 2023
@plarocque4 plarocque4 deleted the questionnaire-package branch January 26, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants