Merged
Conversation
…ent. A NULL will be transformed into an array of size 0.
As often, we forgot to look in bindings. Thanks to Alx Sa for reminding me of these.
gimp_procedure_new_return_values() takes ownership of the passed GError (it allows, among other things, to call it directly as return value). So we must not try and free it afterwards.
…ns object. I had this one crash upon exit, inside gimp_align_options_update_area() as a consequence of gimp_align_options_image_changed() being called on an image change. I could not reproduce after this one time and it's very likely a race condition when everything is getting finalized, and the tool options object is getting finalized earlier than the user context. Anyway this should fix the potential crash.
In Preferences > Toolbox, clicking on an item below the initial scroll window view causes it to jump to the top automatically. This patch prevents this by setting the clicked index in the GtkTreeView before grabbing focus.
I added a few specific validations for range types (int, double…), and a generic validation at the end, meant to catch all yet uncaught invalid argument cases (yet with less details on the what and why).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )