Skip to content

Fix font-size, add max-height, reduce z-index#3

Merged
mdbassit merged 1 commit into
mdbassit:mainfrom
s-pyadyshev:fix/styles
May 11, 2023
Merged

Fix font-size, add max-height, reduce z-index#3
mdbassit merged 1 commit into
mdbassit:mainfrom
s-pyadyshev:fix/styles

Conversation

@s-pyadyshev

Copy link
Copy Markdown
Contributor

Replaced font-size from em to rem. Otherwise inheritance from parent could make the font-size in select too big e.g.
Changed height to auto and added max-height in case of small amount of options. Now the select options' container is too long if there is not too many options.
Reduced z-index to avoid possible overlappings with existing styles of any project.

@mdbassit

Copy link
Copy Markdown
Owner

The font-size and max-height are a good idea, though they may break the styling for existing users. I need to test that first.

Reduced z-index to avoid possible overlappings with existing styles of any project.

I'm not sure what possible overlapping you are referring to, could you give me an example?

@s-pyadyshev

Copy link
Copy Markdown
Contributor Author

For example, existing project with fixed header, tooltips, modals etc with z-index from 1 to 999. Then select with too high z-index may overlap those components. It's common to adjust z-indexes everywhere for sure, just prefer to reduce too big z-indexes and keep them in 1-10 range.

@mdbassit

Copy link
Copy Markdown
Owner

I admit I set those defaults to suit my own needs, but you are right that a z-index of 1 should be enough here.
I'll merge your PR once I do a little testing. Thank you for you contribution :)

@mdbassit mdbassit merged commit b1dd93c into mdbassit:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants