Fix a couple build issues#66
Merged
Merged
Conversation
Fixes mdevctl#65 Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
In order to diagnose build failures when building an rpm, set RUST_BACKTRACE=1 and MDEVCTL_LOG=debug Related: mdevctl#64 Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
There is a race that causes callout scripts to occasionally fail to execute during the test suite. This is caused by the fact that the test suite is run in multiple threads and the fact that callout scripts are copied into a temporary test environment directory. See golang/go#22315 for a thorough description of the root cause of a similar problem encountered by the 'go' compiler. Fixes: mdevctl#64. Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Apparently a new compiler version in the cli infrastructure is generating new clippy warnings. Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Member
|
Looks good to me. |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alex found a couple issues while packaging the 1.2.0 release for fedora. This branch addresses both of them.