29786 ship light dark - #30244
Merged
Merged
Conversation
dletorey
requested review from
a team,
estelle and
zfox23
and removed request for
a team
November 13, 2023 17:02
github-actions
Bot
added
Content:CSS
This was referenced Nov 13, 2023
Contributor
Preview URLs (6 pages)External URLs (1)URL:
(comment last updated: 2023-11-17 09:38:39) |
estelle
reviewed
Nov 14, 2023
estelle
left a comment
estelle
left a comment
Member
There was a problem hiding this comment.
the content is excellent. I am being pedantic while hopefully making it even clearer.
teoli2003
pushed a commit
to mdn/data
that referenced
this pull request
Nov 14, 2023
### Description Added the `light-dark()` CSS color function syntax ### Motivation Working on [Issue 29786](mdn/content#29786) for the release of `light-dark()` CSS color function in Firefox 120 ### Additional details [Bugzilla 1856999](https://bugzilla.mozilla.org/show_bug.cgi?id=1856999) ### Related issues and pull requests - [Content Pull Request](mdn/content#30244) - [BCD Pull Request](mdn/browser-compat-data#21226)
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tent into 29786-ship-light-dark
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
estelle
reviewed
Nov 14, 2023
estelle
left a comment
estelle
left a comment
Member
There was a problem hiding this comment.
A few more comments, then i think we're good to go.
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
… would be the darker and vice versa
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
estelle
approved these changes
Nov 17, 2023
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Have documented the
light-dark()CSS color function and created links and references on the appropriate pagesMotivation
Working on Issue 29786 for the release of
light-dark()CSS color function in Firefox 120Additional details
Bugzilla 1856999
Related issues and pull requests