Skip to content

Refactor using pointer events example - #34909

Merged
Josh-Cena merged 5 commits into
mdn:mainfrom
erwanvivien:evi/improve-using-pointer-events
Aug 10, 2024
Merged

Refactor using pointer events example#34909
Josh-Cena merged 5 commits into
mdn:mainfrom
erwanvivien:evi/improve-using-pointer-events

Conversation

@erwanvivien

@erwanvivien erwanvivien commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Description

Tries to fix #34904

Motivation

Additional details

Related issues and pull requests

@github-actions github-actions Bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed merge conflicts 🚧 [PR only] labels Jul 18, 2024
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions

github-actions Bot commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

Preview URLs

(comment last updated: 2024-08-10 19:31:16)

@Josh-Cena

Copy link
Copy Markdown
Member

@erwanvivien Hi, are you going to keep working on this?

@erwanvivien

Copy link
Copy Markdown
Contributor Author

Hey @Josh-Cena happy to. I left comments here: #34904

Basically saying that I'm not sure how to interleave explanations and code

@Josh-Cena

Copy link
Copy Markdown
Member

Are you unsure about editorial conventions or just what explanation to put down in general? Unfortunately I don't think the reviewers can help you much on writing out all the English without us actually doing it for you—but if you think that's necessary, you can definitely say so and one of the maintainers could take it over.

@erwanvivien

Copy link
Copy Markdown
Contributor Author

just what explanation to put down in general

I think that would probably be that, in fact I think the previous explanations were kind of redundant with the code. That said I don't know who's the target of such page, is that experimented programmers?

one of the the maintainers could take it over

I'd appreciate that 🙏

@Josh-Cena

Josh-Cena commented Aug 10, 2024

Copy link
Copy Markdown
Member

That said I don't know who's the target of such page, is that experimented programmers?

That usually depends on the advancedness of the API itself. For example you can usually assume people reading about Proxy are experienced with JavaScript and people reading about WebGL is experienced with programming (but not necessarily JS). For this one, some level of familiarity with web APIs and JS is expected.

I think the previous explanations were kind of redundant with the code

I agree; which is not uncommon for old content because people come and go and put whatever they think is necessary here.

@github-actions github-actions Bot removed the merge conflicts 🚧 [PR only] label Aug 10, 2024
@Josh-Cena

Copy link
Copy Markdown
Member

I looked at the code. It's big enough that we need to split them into chunks and explain each one. Remember that we are on a guide page anyway, so we need to explain how we arrive at each step. Code here is for demonstration, not for copy/pasting into your own application without knowing how it works.

@Josh-Cena Josh-Cena changed the title feat: add example to Using Pointer Events page Refactor using pointer events example Aug 10, 2024
@Josh-Cena
Josh-Cena marked this pull request as ready for review August 10, 2024 19:16
@Josh-Cena
Josh-Cena requested review from a team and sideshowbarker and removed request for a team August 10, 2024 19:16
@github-actions github-actions Bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Aug 10, 2024

@Josh-Cena Josh-Cena left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some refactors and little fixes. Our code is no longer consistent with the dom-examples repo and we self-host this live example anyway, so I've removed the links to that. Thanks for the PR!

@Josh-Cena
Josh-Cena merged commit 3540592 into mdn:main Aug 10, 2024
@erwanvivien

Copy link
Copy Markdown
Contributor Author

@Josh-Cena thanks for pushing this to the finish line! I was in vacation, sorry for the late reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pointer Events incoherence

2 participants