[Editorial review] BiDi - Add pages for navigation and page load events of browsingContext module - #44571
Open
dipikabh wants to merge 14 commits into
Open
[Editorial review] BiDi - Add pages for navigation and page load events of browsingContext module#44571dipikabh wants to merge 14 commits into
dipikabh wants to merge 14 commits into
Conversation
dipikabh
requested review from
hamishwillee and
pepelsbey
and removed request for
a team
June 25, 2026 00:32
dipikabh
requested review from
a team
and removed request for
hamishwillee and
pepelsbey
June 25, 2026 00:33
Contributor
dipikabh
commented
Jun 25, 2026
juliandescottes
left a comment
Contributor
There was a problem hiding this comment.
(answers for the inline questions, reviewing the rest of the PR still, thanks!)
juliandescottes
requested changes
Jun 30, 2026
juliandescottes
left a comment
Contributor
There was a problem hiding this comment.
Thanks, just some comments on my end, will take another look once they are addressed.
Contributor
Author
|
Thanks a lot for the review, @juliandescottes! Let me know what you think and if any more updates are needed. Thanks! |
Contributor
Author
|
Thanks @juliandescottes for checking. @pepelsbey, sending to you now for an editorial review. |
juliandescottes
approved these changes
Jul 17, 2026
juliandescottes
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dipikabh !
Some additional comments, but I think this is good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds pages for the following navigation and page load events:
browsingContext.navigationStartedbrowsingContext.navigationCommittedbrowsingContext.domContentLoadedbrowsingContext.loadbrowsingContext.navigationFailedbrowsingContext.fragmentNavigatedbrowsingContext.historyUpdatedNote
browsingContext.navigationAbortedis not documented yet. The BCD key is also missing for this event. I'll cover it when there is an implementation.Spec links
Related issue
Doc issue: mdn/mdn#851