chore(filecheck): drop index.html support and fs-extra#44608
Merged
Conversation
We migrated all documents to `index.md` long ago, so only the adjacent `index.md` is considered when checking whether an attachment is referenced. Consolidate the test fixtures into a single `md` directory accordingly.
`node:fs/promises` covers everything we used `fs-extra` for: a small `pathExists` helper wraps `fs.access`, `fse.copyFileSync` becomes `fs.copyFile`, and `fse.removeSync` becomes `fs.rm` with `recursive` and `force`. Drop the `fs-extra` dependency.
github-actions
Bot
added
system
Read the adjacent `index.md` directly and throw the "no document file" `FixableError` on failure, instead of a separate `fs.access` probe. Removes the single-use `pathExists` helper and the extra filesystem round-trip.
Move fixture files up one level and rename the `MD_FIXTURES` constant to `FIXTURES`, since the `md` subdirectory is the only fixtures directory.
caugner
changed the title
index.html support and fs-extraindex.html support and fs-extra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the filecheck script:
index.htmlsupport, so only the adjacentindex.mdis considered when checking whether an attachment is referenced.fs-extrawithnode:fs/promisesand drop the dependency.Motivation
All documents migrated to
index.mdlong ago, so theindex.htmlfallback is dead code.node:fs/promisescovers everything we usedfs-extrafor, so the extra dependency is no longer needed.Additional details
fixtures, dropping the now-redundant duplicate "not mentioned" test.fse.exists→ the adjacentindex.mdis read directly, throwing the "no document file" error when the read fails;fse.copyFileSync→fs.copyFile;fse.removeSync→fs.rm(..., { recursive: true, force: true }).Related issues and pull requests