Update description of how to set offsetNanoseconds#44668
Merged
Conversation
github-actions
Bot
added
Content:JS
Contributor
Josh-Cena
approved these changes
Jul 8, 2026
Josh-Cena
left a comment
Josh-Cena
left a comment
Member
There was a problem hiding this comment.
Oh, nice catch, and great fix. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the description of the
offsetNanosecondsproperty to clarify how to change theoffsetproperty.Motivation
The current docs imply that you can set the
offsetproperty directly. However, the set accessor ofoffsetis alsoundefined. This PR copies language from theoffsetpage to explain how to change theoffsetof aZonedDateTime.Additional details
None
Related issues and pull requests
None