Clarify that Element.slot reflects the attribute - #44687
Open
cdoublev wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
Content:WebAPI
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-07-13 10:54:33) |
chrisdavidmills
requested changes
Jul 13, 2026
chrisdavidmills
left a comment
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
Makes sense, thanks @cdoublev. I just had a couple of minor text suggestions for you to consider.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change defines that
Element.slotreflects theslotglobal attribute, even if the element is not actually slotted.Motivation
I was misled by the current definition, which led me to think that the property represents the name of the slot where the element is actually placed.
Additional details
Related issues and pull requests