Skip to content

CSS properties: intro sentence in values section part 3 - #44936

Open
estelle wants to merge 3 commits into
mdn:mainfrom
estelle:valuetest
Open

CSS properties: intro sentence in values section part 3#44936
estelle wants to merge 3 commits into
mdn:mainfrom
estelle:valuetest

Conversation

@estelle

@estelle estelle commented Jul 27, 2026

Copy link
Copy Markdown
Member

CSS properties include a "Values" section.
Sometimes there is an intro to the values. sometimes there isn't.
This is the third PR in an attempt to make things consistent. This PR addresses some of the properties that had no intro sentence in the values section that and didn't need a whole bunch of other work done

continuation of #44833

@estelle
estelle requested a review from a team as a code owner July 27, 2026 17:06
@estelle
estelle requested review from dipikabh and removed request for a team July 27, 2026 17:06
@github-actions github-actions Bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 27, 2026
Comment thread files/en-us/web/css/reference/properties/font-language-override/index.md Outdated
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor
Preview URLs (23 pages)
Flaws (15)

Note! 16 documents with no flaws that don't need to be listed. 🎉

Found an unexpected or unresolvable flaw? Please report it here.

URL: /en-US/docs/Web/CSS/Reference/Properties/clip
Title: clip CSS property
Flaw count: 4

  • macros:
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/top which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/right which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/bottom which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/left which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/column-count
Title: column-count CSS property
Flaw count: 1

  • macros:
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/column-gap
Title: column-gap CSS property
Flaw count: 1

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/column-rule
Title: column-rule CSS property
Flaw count: 3

  • macros:
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve
    • Macro cssxref produces link /en-US/docs/Web/CSS/rule which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/counter-increment
Title: counter-increment CSS property
Flaw count: 1

  • macros:
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/counter-set
Title: counter-set CSS property
Flaw count: 1

  • macros:
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve

URL: /en-US/docs/Web/CSS/Reference/Properties/fill
Title: fill CSS property
Flaw count: 4

  • macros:
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/url which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/number-token which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/url which doesn't resolve
    • Macro csssyntax produces link /en-US/docs/Web/CSS/Reference/Values/hash-token which doesn't resolve

(comment last updated: 2026-07-29 08:33:07)

estelle and others added 2 commits July 28, 2026 14:37
…e/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
editing it elsewhere and don't want conflicts

@dipikabh dipikabh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for making the placement consistent across the property pages!

That said, I believe these changes deviate from the guideline we have at https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Syntax_sections#css_reference_syntax, which advises to place the optional text before "Values". If we're settling on consistently including the "Optional explanation text" inside the "Values section", would you mind updating that guidance as well?

While I like having the lead-in line in "Values", I'd prefer it to not repeat the values and keywords, since they are named again in the list that follows immediately after. The part we want to emphasize is how many values and how they are separated. I've added suggestions inline.

### Values

The `column-rule` property accepts a comma-separated list of values, including:
This property is specified as a comma-separated list of values, each value being one of the following value types:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This property is specified as a comma-separated list of values, each value being one of the following value types:
This property is specified as a comma-separated list of values. Each value can be one of the following value types:

@@ -79,7 +79,7 @@ Generally, `flex-shrink` is used alongside the {{cssxref("flex-grow")}} and {{cs

## Values

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs to be moved before "Description"

Suggested change
## Values
### Values

font-language-override: unset;
```

The `font-language-override` property is specified as the keyword `normal` or a `<string>`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate:

Suggested change


### Values

This property is specified as a `<dashed-ident>`, a `paletter-mix()` function, or one of the following keyword values:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The listed values are not just the keywords but also include <dashed-ident> and palette-mix(). Can we update this to:

Suggested change
This property is specified as a `<dashed-ident>`, a `paletter-mix()` function, or one of the following keyword values:
This property is specified as a single value from the following list:


### Values

This property is specified as one of the following keyword values or a `dynamic-range-limit-mix()` function:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This property is specified as one of the following keyword values or a `dynamic-range-limit-mix()` function:
This property is specified as a single value from the following list:


### Values

This property is specified as a `<string>` or the keyword `normal`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This property is specified as a `<string>` or the keyword `normal`:
This property is specified as a single value from the following list:

- One of the shorthand values `strict` or `content`

The keywords have the following meanings:
This property is specified as the keyword `none`, `strict`, or `content`, or a space-separated list of keyword values:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This info from original looks crucial - "one or more"

Suggested change
This property is specified as the keyword `none`, `strict`, or `content`, or a space-separated list of keyword values:
This property is specified as a single value (`none`, `strict`, or `content`) or as a space-separated list of one or more of `size` (or `inline-size`), `layout`, `style`, and `paint`, in any order:


### Values

The `counter-set` property is specified as either a space-separated list of `<custom-ident>` values, each optionally followed by an `<integer>`, or the keyword `none`:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `counter-set` property is specified as either a space-separated list of `<custom-ident>` values, each optionally followed by an `<integer>`, or the keyword `none`:
This property is specified as either a space-separated list of `<custom-ident>` values, each optionally followed by an `<integer>`, or the keyword `none`:

## Values

The `flex-shrink` property is specified as a single `<number>`.
This property is specified as one `<number>` value:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This property is specified as one `<number>` value:
This property is specified as the following value:

### Values

This property is specified as one keyword, `<color>`, or `url()` with an optional `<color>`:
This property is specified as a `<color>`, a `url()` optionally followed by a `<color>` or the keyword `none`, or one of the following keyword values:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This again mixes "one of the following keyword values" when the list also includes <color>, <url>, and none. The description for <url> already covers the values that can be optionally attached so we can drop that detail from this lead-in prose:

Suggested change
This property is specified as a `<color>`, a `url()` optionally followed by a `<color>` or the keyword `none`, or one of the following keyword values:
This property is specified as a single value from the following list or as two values when using `<url>`:

@dipikabh dipikabh mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants