Update customized built-in element example to match its source - #44978
Open
quepasaquepasa wants to merge 1 commit into
Open
Update customized built-in element example to match its source#44978quepasaquepasa wants to merge 1 commit into
quepasaquepasa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44952
The
ExpandingListsnippet in the "Customized built-in elements" section was still the pre-mdn/web-components-examples#81 version, which:selfin the constructor (self = super()), clobbering the global {{domxref("Window.self")}}. Even scoped to a module variable this would be wrong, since it only ever points at the most recently constructed instance, so a page with more than one expanding list would have every callback operate on the last one.super(), which the implicit constructor already does.This syncs the snippet with the current source: no constructor,
thisinstead ofself,for…ofover the live NodeLists instead ofArray.from(...).forEach(...), and optional chaining onchildText.parentNode.The surrounding prose is updated to match — it no longer says "most of the code" is in
connectedCallback()(now all of it is), and briefly explains why there's no constructor and whatthisrefers to, which is the explanation the issue asked for.