Add HTML Processing Instruction docs - #45104
Conversation
chrisdavidmills
left a comment
There was a problem hiding this comment.
Nice work here, @tunetheweb. I've left quite a few comments, but these are mainly to do with grammar and page structure stuff. Nothing too serious.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
|
Thanks for the detailed review again @chrisdavidmills ! Think I've addressed it all now. Many (most?) of the comments you noted were issues with the Element equivalents of these pages (e.g. Element.setAttribute, but given the size of those docs, and issues affect other pages in that section as well, I'm not volunteering to make the same changes there - sorry/not sorry 😊 @noamr could you have a look over this before we merge to make sure I'm speaking the truth here? |
Co-authored-by: Noam Rosenthal <noamr@users.noreply.github.com>
|
Technical LGTM |
|
Just two spots from me @chrisdavidmills . Other than those, happy with your edits. |
Co-authored-by: Barry Pollard <barrypollard@google.com>
chrisdavidmills
left a comment
There was a problem hiding this comment.
@tunetheweb Verrrrry nearly there. Just a couple more small bits for you to ponder.
Co-authored-by: Barry Pollard <barrypollard@google.com>
chrisdavidmills
left a comment
There was a problem hiding this comment.
Aaaaand we're done. Thanks again, @tunetheweb.
Description
Chrome 150 supports Processing Instructions in HTML documents.
Prior to this they were treated as comments by all browsers as noted in the current docs
This warning is now no longer accurate.
Chrome also added some extra methods (
getAttribute,getAttributeNames...etc) similar to the equivalents onElementso this PR adds those docs (based on the Element versions).Motivation
Incorrect and missing docs
Additional details
https://chromestatus.com/feature/6534495085920256
Related issues and pull requests