Skip to content

Conversation

@whimboo
Copy link
Contributor

@whimboo whimboo commented Sep 10, 2021

This PR adds documentation for the webSocketUrl capability that is provided by the WebDriver BiDi specification.

@whimboo whimboo requested a review from a team as a code owner September 10, 2021 18:10
@whimboo whimboo requested review from teoli2003 and removed request for a team September 10, 2021 18:10
@whimboo whimboo marked this pull request as draft September 10, 2021 18:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/WebDriver/Capabilities/webSocketUrl
Title: webSocketUrl
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

URL: /en-US/docs/Web/WebDriver/Capabilities/acceptInsecureCerts
Title: acceptInsecureCerts
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NavigateTo
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

URL: /en-US/docs/Web/WebDriver/Capabilities/firefoxOptions
Title: firefoxOptions
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/NewSession

External URLs

URL: /en-US/docs/Web/WebDriver/Capabilities/webSocketUrl
Title: webSocketUrl
on GitHub


URL: /en-US/docs/Web/WebDriver/Capabilities/acceptInsecureCerts
Title: acceptInsecureCerts
on GitHub

No new external URLs


URL: /en-US/docs/Web/WebDriver/Capabilities/firefoxOptions
Title: firefoxOptions
on GitHub

(this comment was updated 2021-09-14 18:44:29.178525)

@whimboo
Copy link
Contributor Author

whimboo commented Sep 10, 2021

@jgraham mind checking if the content for webSocketUrl looks fine to you? Thanks.

@whimboo
Copy link
Contributor Author

whimboo commented Sep 10, 2021

Please note that I will take care of the missing pages for WebDriver/Commands/NewSession and WebDriver/Commands/NavigateTo in the next days.

Copy link

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks accurate and reasonable to me.

@whimboo whimboo marked this pull request as ready for review September 10, 2021 19:30
@teoli2003 teoli2003 removed their request for review September 11, 2021 08:02
@teoli2003 teoli2003 added the Content:WebDriver WebDriver docs label Sep 11, 2021
@whimboo
Copy link
Contributor Author

whimboo commented Sep 13, 2021

@teoli2003 could you please review?

@whimboo
Copy link
Contributor Author

whimboo commented Sep 14, 2021

I talked with @sideshowbarker on Element and he will take care of the final review and merge once the branches are open again. Thanks!

@mdn mdn deleted a comment Sep 14, 2021
@mdn mdn deleted a comment Sep 14, 2021
@sideshowbarker sideshowbarker merged commit 11101e2 into mdn:main Sep 14, 2021
@whimboo whimboo deleted the websocketUrl branch September 14, 2021 19:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Content:WebDriver WebDriver docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants