This repository was archived by the owner on Oct 17, 2025. It is now read-only.
highlight gotchas of array sort #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array sort does not work for numbers. It is important to highlight this.
|
💖 Thanks for opening this pull request! 💖
|
wbamberg
approved these changes
Feb 7, 2019
Contributor
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
This is a nice change, thank you @godfreyhobbs !
|
Congrats on merging your first pull request! 🎉🎉🎉 |
wbamberg
pushed a commit
to CShepartd/interactive-examples
that referenced
this pull request
Feb 8, 2019
…low-wrap * upstream/master: chore(deps): update dependency all-contributors-cli to v6 (mdn#1313) chore(deps): update dependency prettier to v1.16.4 (mdn#1304) chore(deps): update dependency ajv to v6.8.1 (mdn#1306) chore(deps): update dependency eslint to v5.13.0 (mdn#1305) chore(deps): update dependency all-contributors-cli to v5.11.0 (mdn#1302) highlight gotchas of array sort (mdn#1308) Small Update Join Docs -- Add quotes to show output as a string (mdn#1307) Add more Intl.RelativeTimeFormat examples (mdn#1300) Add example for globalThis (mdn#1299) Add travisbuddy to Travis config (mdn#1301) chore(deps): update dependency prettier to v1.16.1 (mdn#1297) chore(deps): update dependency mdn-bob to v1.1.23 (mdn#1296) chore(deps): update dependency stylelint to v9.10.1 (mdn#1291) chore(deps): update dependency eslint to v5.12.1 (mdn#1295) chore(deps): update dependency all-contributors-cli to v5.10.2 (mdn#1288) [Snyk] Fix for 1 vulnerable dependencies (mdn#1294) text-transform: full-size-kana value (mdn#1289) renamed function findFirstLargeNumber to isLargeNumber (mdn#1293)
wbamberg
pushed a commit
to dehuszar/interactive-examples
that referenced
this pull request
Feb 22, 2019
* upstream/master: (36 commits) Add example of string replace without regex (mdn#1321) Revert "added anywhere value to overflow-wrap property" (mdn#1311) chore(deps): update dependency all-contributors-cli to v6 (mdn#1313) chore(deps): update dependency prettier to v1.16.4 (mdn#1304) chore(deps): update dependency ajv to v6.8.1 (mdn#1306) chore(deps): update dependency eslint to v5.13.0 (mdn#1305) chore(deps): update dependency all-contributors-cli to v5.11.0 (mdn#1302) highlight gotchas of array sort (mdn#1308) Small Update Join Docs -- Add quotes to show output as a string (mdn#1307) Add more Intl.RelativeTimeFormat examples (mdn#1300) Add example for globalThis (mdn#1299) Add travisbuddy to Travis config (mdn#1301) chore(deps): update dependency prettier to v1.16.1 (mdn#1297) chore(deps): update dependency mdn-bob to v1.1.23 (mdn#1296) chore(deps): update dependency stylelint to v9.10.1 (mdn#1291) chore(deps): update dependency eslint to v5.12.1 (mdn#1295) chore(deps): update dependency all-contributors-cli to v5.10.2 (mdn#1288) [Snyk] Fix for 1 vulnerable dependencies (mdn#1294) text-transform: full-size-kana value (mdn#1289) renamed function findFirstLargeNumber to isLargeNumber (mdn#1293) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array sort does not work for numbers. It is important to highlight this.