Revert "added anywhere value to overflow-wrap property" #1311
Conversation
This reverts commit db3d54b.
This reverts commit 2184689.
This reverts commit 4728786.
This reverts commit 8d28f27.
This reverts commit d40e449.
This reverts commit d864037.
This reverts commit e44c407.
This reverts commit 90bd284.
This reverts commit 56691ca.
)" This reverts commit 1476a66.
This reverts commit d4da008.
|
@estelle , would you mind looking at this? |
|
LGTM. |
|
Sorry @estelle , I should have been clearer. This PR reverts the example which we added in #1284, on the grounds that The first iteration of that PR didn't show the difference between I'm not familiar enough with this property to know whether it's true that So I think just merging this PR is not enough: if we do want an example for Can you take this on, since you originally updated the page to add |
|
I thought you just wanted to revert the example at the top. As it also doesn't yet work in all browsers and you can't really tell the difference, i am fine with reverting it. The examples do need to be redone, as overflow-wrap/word-wrap property only works on inline boxes, and the examples through out the page are on block level elements. |
|
@schalkneethling , this PR is showing a snyk failure, although I don't see anything in the actual change to reflect that. What do you think? |
It is one of our dependencies that needs to be updated. Not introduced here. This is fine to merge. |
|
@wbamberg Probably a good idea to rebase this against master as I have updated a couple of the dependencies. |
…low-wrap * upstream/master: chore(deps): update dependency all-contributors-cli to v6 (mdn#1313) chore(deps): update dependency prettier to v1.16.4 (mdn#1304) chore(deps): update dependency ajv to v6.8.1 (mdn#1306) chore(deps): update dependency eslint to v5.13.0 (mdn#1305) chore(deps): update dependency all-contributors-cli to v5.11.0 (mdn#1302) highlight gotchas of array sort (mdn#1308) Small Update Join Docs -- Add quotes to show output as a string (mdn#1307) Add more Intl.RelativeTimeFormat examples (mdn#1300) Add example for globalThis (mdn#1299) Add travisbuddy to Travis config (mdn#1301) chore(deps): update dependency prettier to v1.16.1 (mdn#1297) chore(deps): update dependency mdn-bob to v1.1.23 (mdn#1296) chore(deps): update dependency stylelint to v9.10.1 (mdn#1291) chore(deps): update dependency eslint to v5.12.1 (mdn#1295) chore(deps): update dependency all-contributors-cli to v5.10.2 (mdn#1288) [Snyk] Fix for 1 vulnerable dependencies (mdn#1294) text-transform: full-size-kana value (mdn#1289) renamed function findFirstLargeNumber to isLargeNumber (mdn#1293)
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
Thanks @CShepartd ! I rebased this PR and the snyk error seems to have gone away.
* upstream/master: (36 commits) Add example of string replace without regex (mdn#1321) Revert "added anywhere value to overflow-wrap property" (mdn#1311) chore(deps): update dependency all-contributors-cli to v6 (mdn#1313) chore(deps): update dependency prettier to v1.16.4 (mdn#1304) chore(deps): update dependency ajv to v6.8.1 (mdn#1306) chore(deps): update dependency eslint to v5.13.0 (mdn#1305) chore(deps): update dependency all-contributors-cli to v5.11.0 (mdn#1302) highlight gotchas of array sort (mdn#1308) Small Update Join Docs -- Add quotes to show output as a string (mdn#1307) Add more Intl.RelativeTimeFormat examples (mdn#1300) Add example for globalThis (mdn#1299) Add travisbuddy to Travis config (mdn#1301) chore(deps): update dependency prettier to v1.16.1 (mdn#1297) chore(deps): update dependency mdn-bob to v1.1.23 (mdn#1296) chore(deps): update dependency stylelint to v9.10.1 (mdn#1291) chore(deps): update dependency eslint to v5.12.1 (mdn#1295) chore(deps): update dependency all-contributors-cli to v5.10.2 (mdn#1288) [Snyk] Fix for 1 vulnerable dependencies (mdn#1294) text-transform: full-size-kana value (mdn#1289) renamed function findFirstLargeNumber to isLargeNumber (mdn#1293) ...
4 participants
Reverts #1284
Nesting
overflow-wrap: anywhereinflexelement is unproperly. For better understand this rule see this example