[MCC-1476025] - Add Publish Function#39
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “live publish” capability to the DataConnect Python SDK, wiring a publish operation end-to-end (client → service → transport) and introducing corresponding transport/domain response models plus comprehensive unit tests.
Changes:
- Introduces
publish()onDataConnectClient/DataConnectService/DefaultDataConnectService, andpublish_dataset()on theTransportinterface. - Implements Arrow Flight transport support for publish, including schema normalization and two-phase metadata parsing (JSON + optional IPC invalid-records table).
- Adds
PublishResponse(transport) andPublishResult(domain) models and mapping viapublish_response_to_domain, with new unit tests.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_publish.py | New test suite covering publish mapper/service/transport/client delegation. |
| tests/test_dry_publish.py | Updates dry-publish tests to satisfy the expanded Transport ABC (adds publish_dataset). |
| dataconnect/transport/models.py | Adds PublishResponse DTO and expands docs around publish request/response models. |
| dataconnect/transport/base.py | Extends the Transport ABC with publish_dataset(). |
| dataconnect/transport/arrow_flight/transport.py | Implements publish_dataset() using Arrow Flight do_put and parses publish metadata. |
| dataconnect/transport/init.py | Re-exports PublishResponse. |
| dataconnect/service/mappers.py | Adds publish_response_to_domain() mapper. |
| dataconnect/service/default.py | Implements DefaultDataConnectService.publish() building PublishRequest and translating errors. |
| dataconnect/service/base.py | Extends DataConnectService interface with publish(). |
| dataconnect/models.py | Adds PublishResult domain model. |
| dataconnect/client.py | Adds DataConnectClient.publish() plus expanded docstrings. |
| dataconnect/init.py | Exports PublishResult from the package root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ibaig-mdsol
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MCC-1476025] - Add Publish Function
Changes