Fix comment prefix and suffix #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `<!--` and `--> were part of comments nodes. this deferred from the HAST specification. This PR removed the prefix when comments are found in markdown, and thus doesn’t need to replace them when rendering to JSX, but rather prefixes and suffixes them. Closes GH-312.
|
This pull request is automatically deployed with Now. |
silvenon
reviewed
Nov 23, 2018
Contributor
silvenon
left a comment
silvenon
left a comment
There was a problem hiding this comment.
Thanks! Could you add a test for this?
timneutkens
reviewed
Nov 23, 2018
timneutkens
reviewed
Nov 23, 2018
Contributor
|
Seeing how I missed the |
Co-Authored-By: wooorm <tituswormer@gmail.com>
Co-Authored-By: wooorm <tituswormer@gmail.com>
timneutkens
approved these changes
Nov 25, 2018
Merged
Member
Author
|
Good catch! Rather not have it in this PR, but posted it in #338 (comment). |
Member
Author
|
@silvenon Fixed! |
silvenon
approved these changes
Nov 25, 2018
Co-Authored-By: wooorm <tituswormer@gmail.com>
Member
Author
|
@silvenon Sure, done! |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
<!--and-->were part of comments nodes.this deferred from the HAST specification.
This PR removed the prefix when comments are found in markdown, and
thus doesn’t need to replace them when rendering to JSX, but rather
prefixes and suffixes them.
Closes GH-312.