CHT External App Launcher by latin-panda · Pull Request #199 · medic/cht-android

latin-panda · 2021-07-30T06:24:41Z

Description

This PR:

Adds a way to launch any external android app from the CHT-Android.
- Webapp triggers this feature and pass the information that an external app may need.
- When the work in the external app is finished, the CHT-Android send the intent's response data (if any) to Webapp.
As first scope: it's going to support numbers, strings, bools, objects, arrays and images.

Ticket: medic/cht-core#6981
PR CHT-Docs
PR CHT-Core

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

…6981-launching-external-apps

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java

latin-panda · 2021-07-30T10:31:29Z

Hi @jkuester, I heard that you have experience with Android and Java, would you please review this draft?
I'd like to receive early feedback as I'm learning my way in Android 🙏
I still have concerns if this code is working in android 5 & 6, because of Java 8 features, so in the meantime I'm going figure out this piece with emulators 🙂
Thanks!

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java

Disabled AndroidGradlePluginVersion lint rule as newer version of the lib requires Java 11 min.

latin-panda · 2021-08-02T09:45:55Z

Hi @jkuester, I think I've done all my pending items:

Fixed the image path support for older sdk
Fixed the inline errors for Java 8 code in older sdks (Android 5 & 6)
Disabled the gradle lint error because the next android.tool.gradle library is version 7, and this version requires JDK 11 👀 I recommend that it's fixed in a separate PR/Ticket so QA can target the testing.
Added more unit tests.

Please let me know any feedback 🙂
@garethbowen welcome to provide feedback too 🙂

I'll be working in the second piece of this feature which is the Enketo widget to process the form and connect with this Android feature.
Thank you!

build.gradle

jkuester

Overall these changes look great! I have added some minor suggestions around the structure/flow and some questions regarding some small parts of the logic.

I have not had a chance to look at the tests yet, but I wanted to at least get these comments in to start with.

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncherActivity.java

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java

src/main/java/org/medicmobile/webapp/mobile/Utils.java

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java

src/webview/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

src/xwalk/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java

latin-panda · 2021-08-04T10:13:14Z

Hi @jkuester Thanks for the feedback and examples, it was good learning, can you please review again? Thanks!

jkuester

Great test cases!

src/main/java/org/medicmobile/webapp/mobile/ChtExternalApp.java

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppHandler.java

src/test/java/org/medicmobile/webapp/mobile/UtilsTest.java

mrsarm · 2021-08-04T23:42:14Z

@latin-panda I have created an issue for the linter issue here: #201 , working on that.

latin-panda · 2021-08-05T06:38:19Z

@jkuester I've applied the feedback, please have a look :)

jkuester

🚀

…6981-launching-external-apps � Conflicts: � build.gradle

latin-panda added 4 commits July 30, 2021 13:20

CHT External App Launcher - simple and complex data handling

c2fc3b4

Lint

df70bba

Merge branch 'master' of https://github.com/medic/medic-android into …

cb22948

…6981-launching-external-apps

Adding image support

a840fe2

latin-panda commented Jul 30, 2021

View reviewed changes

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java Outdated Show resolved Hide resolved

latin-panda requested a review from jkuester July 30, 2021 10:26

latin-panda commented Jul 30, 2021

View reviewed changes

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java Outdated Show resolved Hide resolved

latin-panda added 3 commits July 31, 2021 12:37

Fixing image support for older android sdk

9bc4b2f

Fixed Java 8 support in older version of android.

7f46ebd

Disabled AndroidGradlePluginVersion lint rule as newer version of the lib requires Java 11 min.

Unit tests for Utils new method

ab6358e

latin-panda marked this pull request as ready for review August 2, 2021 09:33

latin-panda commented Aug 2, 2021

View reviewed changes

build.gradle Show resolved Hide resolved

jkuester reviewed Aug 2, 2021

View reviewed changes

garethbowen reviewed Aug 2, 2021

View reviewed changes

src/main/java/org/medicmobile/webapp/mobile/ChtExternalAppLauncher.java Outdated Show resolved Hide resolved

garethbowen reviewed Aug 2, 2021

View reviewed changes

src/webview/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java Outdated Show resolved Hide resolved

src/xwalk/java/org/medicmobile/webapp/mobile/MedicAndroidJavascript.java Outdated Show resolved Hide resolved

latin-panda added 3 commits August 3, 2021 21:12

Feedback

16fa84e

Fixing support for js script size.

686270c

Refactoring structure

dd08c63

latin-panda requested a review from jkuester August 4, 2021 10:12

jkuester reviewed Aug 4, 2021

View reviewed changes

latin-panda added 2 commits August 5, 2021 11:20

Feedback

9564bf2

oops, lint

251a743

latin-panda requested a review from jkuester August 5, 2021 06:37

jkuester approved these changes Aug 5, 2021

View reviewed changes

latin-panda mentioned this pull request Aug 12, 2021

6981 launching external apps medic/cht-core#7248

Merged

5 tasks

latin-panda mentioned this pull request Aug 14, 2021

6981 - documentation for android-app-launcher, display-base64-image and parse-timestamp-to-date medic/cht-docs#540

Merged

Merge branch 'master' of https://github.com/medic/medic-android into …

a010066

…6981-launching-external-apps � Conflicts: � build.gradle

latin-panda mentioned this pull request Aug 16, 2021

Support collecting form data from external Android apps medic/cht-core#6981

Closed

mrjones-plip mentioned this pull request Aug 31, 2021

FIND COVID-19 RDT Grant Deliverables - Due October 3rd medic/cht-core#7285

Closed

7 tasks

mrsarm added this to the 0.10.0 milestone Sep 10, 2021

latin-panda merged commit b7a7a8d into master Sep 15, 2021

latin-panda deleted the 6981-launching-external-apps branch September 15, 2021 15:18

mrsarm mentioned this pull request Sep 15, 2021

Release v0.10.0 #211

Closed

7 tasks

Conversation

latin-panda commented Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

latin-panda commented Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

latin-panda commented Aug 2, 2021

Uh oh!

Uh oh!

jkuester left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

latin-panda commented Aug 4, 2021

Uh oh!

jkuester left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrsarm commented Aug 4, 2021

Uh oh!

latin-panda commented Aug 5, 2021

Uh oh!

jkuester left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

latin-panda commented Jul 30, 2021 •

edited

Loading

latin-panda commented Jul 30, 2021 •

edited

Loading