Skip to content

Upgrade Android Gradle Plugin → 7.0.2#209

Merged
mrsarm merged 2 commits intomasterfrom
android-gradle-plugin-7.0.2
Sep 3, 2021
Merged

Upgrade Android Gradle Plugin → 7.0.2#209
mrsarm merged 2 commits intomasterfrom
android-gradle-plugin-7.0.2

Conversation

@mrsarm
Copy link
Contributor

@mrsarm mrsarm commented Sep 3, 2021

Upgrade to the latest Gradle plugin in order to make the linter to work again. Looks like we are going to have a PR like this each week 🤷‍♂️ .

@mrsarm mrsarm added the Type: Technical issue Improve something that users won't notice label Sep 3, 2021
@mrsarm mrsarm requested review from jkuester and latin-panda and removed request for latin-panda September 3, 2021 14:03
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason the linter is forcing us to be on the latest patch of gradle? Is this something we could configure in the linter so that we don't have to continuously bump this version (but instead can just update it in the same way we do the rest of the dependencies...)?

@mrsarm
Copy link
Contributor Author

mrsarm commented Sep 3, 2021

Is there a particular reason the linter is forcing us to be on the latest patch of gradle? Is this something we could configure in the linter so that we don't have to continuously bump this version (but instead can just update it in the same way we do the rest of the dependencies...)?

Right, it's a new check and looking into the documentation, we can disable it like other linters in build.gradle with:

disable 'AndroidGradlePluginVersion'

But to keep it performing the check I found a new trick that will keep it checking the version but not stopping the process with an error just for this: https://github.com/medic/cht-android/pull/209/files#diff-eefab2907910dd29e3d63b35664b4bdee63bb6b8b64d1238d8bee937f015fe9bR7.

@mrsarm mrsarm merged commit f9bc1e1 into master Sep 3, 2021
@mrsarm mrsarm deleted the android-gradle-plugin-7.0.2 branch October 1, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Technical issue Improve something that users won't notice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants