Skip to content

7128-Medic rebrand#7204

Merged
latin-panda merged 9 commits intomasterfrom
7128-medic-rebrand-in-core
Aug 10, 2021
Merged

7128-Medic rebrand#7204
latin-panda merged 9 commits intomasterfrom
7128-medic-rebrand-in-core

Conversation

@latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Jul 19, 2021

Description

This PR:

  • Updates the logo and its spacing in the login page.
  • Updates the favico and page title.
  • Fixes minor css spacing.
  • Updates dev@medicmobile.org and hello@medicmobile.org to @medic.org domain.
  • Update "Medic Mobile" to "Medic" in strings, documentation and comments, however legal documents remains with legal name (copyright and licenses)

Note: Colours won't be updated as they require an UX study, font's are already in Noto-sans and title won't change for now.

Ticket: #7128
CHT-Android: medic/cht-android#195

Screenshots of new logo:
1 Logo updated.

2 Logo, favico and page title already updated.

Screenshots of css fixes:

1 Spacing and dropdown cutting the selected item text
Screen Shot 2021-07-19 at 5 05 12 pm

2 Circle with checkboxes and numbers display is off.
Screen Shot 2021-07-19 at 4 50 57 pm

3 Circle with checkboxes and numbers display is off.
Screen Shot 2021-07-07 at 12 35 08 am

4 Filter spacing uneven.
Screen Shot 2021-07-07 at 12 30 04 am

5 Spacing between elements.
Screen Shot 2021-07-07 at 12 24 04 am

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda marked this pull request as ready for review July 20, 2021 07:08
@latin-panda
Copy link
Contributor Author

Hi @njogz, can you please have a look :) Thanks!

Copy link
Contributor

@njogz njogz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this. Just one question about a section where you still have Medic Mobile.

@latin-panda latin-panda merged commit 356d66e into master Aug 10, 2021
@latin-panda latin-panda deleted the 7128-medic-rebrand-in-core branch August 10, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants