Fix certbot cronjob: remove TTY flags and ensure nginx reloads only on certbot success#2153
Closed
Fix certbot cronjob: remove TTY flags and ensure nginx reloads only on certbot success#2153
Conversation
…ode-from certbot Co-authored-by: 1yuv <6102813+1yuv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on nginx restart in certbot cronjob PR
Fix certbot cronjob: remove TTY flags and ensure nginx reloads only on certbot success
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented certbot renewal cronjob had two bugs:
-itflags ondocker execcause failures in cron (no TTY), anddocker compose upexits zero even when certbot fails, causing nginx to reload with stale or no new certs.Changes
-itfromdocker execin cronjob — cron has no TTY; flags are only appropriate for interactive use (kept in the manual step 6)--abort-on-container-exit --exit-code-from certbot— propagates certbot's exit code so the&&chain gates nginx reload on actual certbot success💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.