Skip to content

Update header layout and theme transition#169

Merged
medyo merged 1 commit intomedyo:developfrom
victor-duarte:fix/update-theme-transition
Oct 1, 2023
Merged

Update header layout and theme transition#169
medyo merged 1 commit intomedyo:developfrom
victor-duarte:fix/update-theme-transition

Conversation

@victor-duarte
Copy link
Copy Markdown
Contributor

@victor-duarte victor-duarte commented Sep 29, 2023

Closes #163

Note

Style fix adjustment vs a logic update.

Updates

  • Update CSS animation to only address elements properties required to be affected by theme avoiding the all value
  • Apply cosmetic updates on header layout
    • Remove unneeded styles
    • Follow mobile first approach
    • Adjust layout in some viewports
    • Update border on some elements (e.g: tags) to avoid shifting between themes
  • Enables search bar in header for small viewports
  • Moves "scroll for dev news..." into view on small viewports
  • Fix Cards internal scroll on small viewports
image image image image image image image

@victor-duarte victor-duarte force-pushed the fix/update-theme-transition branch from 77c1201 to ae4e63d Compare September 29, 2023 16:20
@medyo
Copy link
Copy Markdown
Owner

medyo commented Sep 30, 2023

Can you fix the search bar width, it looks too small in the DND mode
image

@medyo
Copy link
Copy Markdown
Owner

medyo commented Sep 30, 2023

Can you also check this
image

@medyo medyo self-requested a review September 30, 2023 12:49
@victor-duarte victor-duarte force-pushed the fix/update-theme-transition branch from ae4e63d to f4b1099 Compare October 1, 2023 01:14
@victor-duarte victor-duarte force-pushed the fix/update-theme-transition branch from f4b1099 to 7e9e7c9 Compare October 1, 2023 01:20
@victor-duarte
Copy link
Copy Markdown
Contributor Author

@medyo, new updates have pushed that handle the header overlap and search input size in DND mode, plus other minor tweaks to improve layout.

Copy link
Copy Markdown
Owner

@medyo medyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @victor-duarte for your valuable help

@medyo medyo merged commit 02b505d into medyo:develop Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants