Skip to content

Enables tab navigation#171

Merged
medyo merged 1 commit intomedyo:developfrom
victor-duarte:fix/tab-navigation
Oct 10, 2023
Merged

Enables tab navigation#171
medyo merged 1 commit intomedyo:developfrom
victor-duarte:fix/tab-navigation

Conversation

@victor-duarte
Copy link
Copy Markdown
Contributor

@victor-duarte victor-duarte commented Oct 1, 2023

Closes #170

Updates

  • Enables tab navigation
    • Tweaks bookmarks icons interaction to allow smooth tab navigation
    • Updates html tag for better semantics and a11y purposes allowing tab navigation
    • Uses default browser outline behavior
  • Display bookmarks cta on small devices to allow user to save bookmark (on large viewports it displays on card hover or focus of the cta)
  • Update aria-labels on some elements for a11y purposes
  • Removed unneeded tags an inline styles
  • Minor alignment updates on small viewports (specifically for devices layout layout in AppContentLayout.tsx) complementing work on Update header layout and theme transition #169

@victor-duarte victor-duarte marked this pull request as draft October 1, 2023 18:32
@victor-duarte victor-duarte changed the base branch from master to develop October 1, 2023 18:32
@victor-duarte victor-duarte marked this pull request as ready for review October 1, 2023 18:32
@medyo
Copy link
Copy Markdown
Owner

medyo commented Oct 8, 2023

Hi @victor-duarte,

Great contribution. I have a couple of comments:

The moon icon appears too bright against a light background
image

Card Header: Could you remove the excess horizontal margins between the title and dropdown?
image

@victor-duarte
Copy link
Copy Markdown
Contributor Author

@medyo an update has been pushed:

  • Moon icon brightness adjustment, also change to use the filled icon which seems to work better with the siblings
    (after / before)
image
  • Reduced block header vertical space by 10px from 54px to 44px.
    (after / before)
image

@medyo
Copy link
Copy Markdown
Owner

medyo commented Oct 9, 2023

  • Reduced block header vertical space by 10px from 54px to 44px.

I was talking about the horizontal space, between the title the dropdown (in red)

image

@victor-duarte
Copy link
Copy Markdown
Contributor Author

doh

  • Updated the space between the items and alignment
  • height reverted to 54px
image

@medyo medyo merged commit 41d5b3c into medyo:develop Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable tab navigation

2 participants