6565 – Deprecate parsers partners#414
Merged
vasconsaurus merged 4 commits intodevelopfrom Oct 22, 2025
Merged
Conversation
vasconsaurus
changed the title
vasconsaurus
force-pushed
the
6565-deprecate-parsers-partners
branch
3 times, most recently
from
4e19a9a to
a580239
Compare
vasconsaurus
force-pushed
the
6565-deprecate-parsers-partners
branch
from
6d22d6f to
8d0278b
Compare
vasconsaurus
force-pushed
the
6565-deprecate-parsers-partners
branch
from
8d0278b to
76c167c
Compare
caiosba
approved these changes
Oct 22, 2025
| end | ||
| AlegreClient.unstub(:get_enrichment_for_url) | ||
| PenderClient.unstub(:get_enrichment_for_url) | ||
| sleep 0.25 |
Contributor
There was a problem hiding this comment.
It's OK to sleep more if it makes it less flaky.
Contributor
Author
There was a problem hiding this comment.
I'll keep it like this for now, and update if we run into issues
vasconsaurus
added a commit
that referenced
this pull request
Oct 23, 2025
Deprecate parsers. References: CV2-6565 Sidenote: This test was failing: spec/lib/db_integration_test.rb. Now that we have only a couple partners, tests were running too fast and ClaimReview was returning nil, which was causing tests to fail. I did the easiest thing I could and added a sleep, with the least amount of time I could, which fixed this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecate parsers.
References: CV2-6565
How has this been tested?
By running the test suite.
Sidenote on the integration test: now that we have only a couple partners, tests were running too fast and ClaimReview was returning nil, which was causing tests to fail. I did the easiest thing I could and added the shortest sleep that got tests to pass.