Remove the Verkle tree implementation#2
Merged
Conversation
yilongli
force-pushed
the
remove-verkle-trie
branch
2 times, most recently
from
July 26, 2025 15:08
2eb3eec to
e0cbdaf
Compare
This commit removes the `verkle-db`, `verkle-trie`, and `verkle-spec` crates from the project. These crates contained an unused and experimental Verkle tree implementation. As a result of this removal: - The `ffi_interface` crate has been cleaned up by removing functions and types that depended on `verkle-spec`, including deprecated hashing functions and proof generation/verification logic. - Numerous transitive dependencies related to the Verkle tree implementation have been removed from `Cargo.lock`, significantly reducing the project's dependency footprint. - The overall project structure is simplified by removing these unused components.
yilongli
force-pushed
the
remove-verkle-trie
branch
from
July 26, 2025 17:13
e0cbdaf to
8cbddfc
Compare
Eliminated the `ffi_interface` crate by inlining its core functionality directly into the `salt` crate.
yilongli
force-pushed
the
remove-verkle-trie
branch
from
July 26, 2025 17:18
8cbddfc to
3869dc2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the Verkle tree implementation by deleting all related source code, tests, benchmarks, and specifications. The change appears to completely eliminate the Verkle trie functionality from the codebase.
Key changes:
- Complete removal of the
verkle-triecrate including core implementation, database layer, and proof system - Removal of the
verkle-speccrate that provided Ethereum-specific Verkle tree key mapping - Deletion of all associated tests, benchmarks, and configuration files
Reviewed Changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| verkle-trie/* | Complete removal of Verkle trie implementation including core logic, database abstractions, proof system, and configuration |
| verkle-spec/* | Removal of Ethereum-specific Verkle tree specification and key mapping utilities |
yilongli
marked this pull request as ready for review
July 26, 2025 17:44
abelmega
approved these changes
Jul 28, 2025
vincent-k2026
pushed a commit
that referenced
this pull request
Jul 11, 2026
Address review feedback on PR #143: - endian.rules / trie.rules / canon.rules: anchor rules to call sites and add word boundaries so they can't match identifier substrings (`serialize_to_le_bytes`) or prefixes (`TRIE_WIDTH_BITS`); make the comparator-flip name-agnostic instead of hardcoding `a`/`b`. (Troublor) - spec_mutation.sh: drop comment-only mutants (universalmutator rewrites inside `///` docs → false SURVIVED), reported not silently discarded. (flyq #1) - spec_mutation.sh: cap lints to allow for the mutant build so a lint-only breakage (unused_mut under CI's -D warnings) isn't miscounted invalid. (flyq #2) - spec_mutation.sh: wrap nextest in a per-mutant timeout so a looping mutant is killed at 900s instead of hanging the job for hours. (flyq #3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.