This repository was archived by the owner on Feb 11, 2025. It is now read-only.
bug/fix resources#1
Merged
Merged
Conversation
javiergm1983
suggested changes
Oct 19, 2020
There was a problem hiding this comment.
Some strings improvements needed. Please take a look to my comments.
In addition there is a problem with other string. As you can see in the following screenshot it says "Upload" where it should say "Add" (see the design).
Apart from that everything seems fine.
javiergm1983
suggested changes
Oct 20, 2020
javiergm1983
left a comment
javiergm1983
left a comment
There was a problem hiding this comment.
I have seen some other problems with the strings. Sorry for not seeing and reporting them yesterday along with the other issues.
javiergm1983
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Any relevant logs, error output, etc?
...
Any other comments?
...
Where has this been tested?
Devices/Simulators:
Google Pixel 4
Google Pixel XL
OS Version:
Android 11
Android 10