Skip to content

Conversation

@tsamaya
Copy link
Contributor

@tsamaya tsamaya commented Oct 16, 2015

No description provided.

@tsamaya tsamaya mentioned this pull request Oct 16, 2015
@tsamaya
Copy link
Contributor Author

tsamaya commented Oct 16, 2015

I also push the commit with Strings economy (#2 Avoid Strings concatenation. It consume too many objects and make Garbage Collector overwork)

@chrismayer
Copy link
Contributor

Hi @tsamaya,

very good additions and improvements. Thanks a lot for this!
One question: Did you add your .gitignore file by purpose?

@tsamaya
Copy link
Contributor Author

tsamaya commented Oct 16, 2015

Hi @chrismayer
Yes I think including a .gitignore file is usefull.

@chrismayer
Copy link
Contributor

Hi @tsamaya,

thanks for your ongoing work.
I agree a .gitignore would be useful. Would you mind splitting up this PR in 2 or 3 separate PRs, so they are separated more thematically? I think about something like:

  • the initial one "Overloading position and words methods with a language"
  • one for adding the .gitignore
  • one for adding the new test

So the review is much easier.

@tsamaya
Copy link
Contributor Author

tsamaya commented Oct 17, 2015

Hi @chrismayer
I have done the first 2 PR.
I am waiting the merged for the last PR with test class.

@chrismayer
Copy link
Contributor

I merged #5 and #6 so I would suggest you can open another PR (if you want to) for the additional test and we close this PR afterwards, since it will be obsolete then.
Thanks for your ongoing effort, @tsamaya !

@tsamaya
Copy link
Contributor Author

tsamaya commented Oct 17, 2015

You are welcome !
I made the new PR #7
have a nice week end

@chrismayer
Copy link
Contributor

Since #5, #6 and #7 are merged I will close this now. Thank you @tsamaya!

@chrismayer chrismayer closed this Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants