Improve coverage #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
This line does not make any sense, does it? Can you remove it please?
Contributor
Author
There was a problem hiding this comment.
Hi, yes it does not have a real sens but in fact, it tests the getLanguage method. I should a real test with it.
Contributor
|
Hi @tsamaya, thanks for this! I really like it to have an improved test coverage. I added some minor line comments. would you mind addressing them? After that I think this is good to go. |
This was referenced Oct 29, 2015
Open
Contributor
Author
|
Hi @chrismayer, |
Contributor
|
Thanks for your ongoing effort on this, @tsamaya! 👍 This is good to go now. I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.