-
Notifications
You must be signed in to change notification settings - Fork 268
Update upgrading guide in installation #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 7.17.0 to 7.18.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.17.0...v7.18.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
* Prepare documentation for release 11/2020 of MeiliSearch * Change documents references * Add lazy index to indexes main concept * Suggestion for lazy index into getting started * Fix type * Apply suggestions from code review Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update guides/introduction/quick_start_guide.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update .vuepress/config.js Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update references/documents.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Remove create index code sample * Update guides/introduction/quick_start_guide.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update guides/main_concepts/indexes.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update guides/main_concepts/indexes.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update documents addition in getting started. Updated primary key definition * Update .vuepress/components/glossary.vue Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update guides/introduction/quick_start_guide.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Fix styling Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to rewrite a lot of the installation-related resources as soon as the restructure (#619 ) is finished, so I am mostly viewing this as a temporary solution, and from that perspective it looks good.
In the future a more detailed guide would be helpful—should also explain how to create and import dumps, and have platform-specific information for Docker + DigitalOcean. Also, I don't like this first sentence: "Updating MeiliSearch is a straightforward process," an idea which we immediately contradict... 😬
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
|
If you have a better alternative for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's this? It's a super small change but I think it gives us more protection from criticism.
(I think we could be criticized since updating is not actually that simple, insofar as updating a production database requires you to create and import dumps)
Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com>
dichotommy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Add information on how to keep data between versions.
Should it be named update or upgrade? @react-learner
Partially fixes: #698
Fixes: #665