Remove axios vulnerability #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @bidoubiwa !! 🙇♂️ |
dichotommy
added a commit
that referenced
this pull request
Jan 22, 2021
* Update upgrading guide in installation * Bump eslint from 7.17.0 to 7.18.0 (#704) Bumps [eslint](https://github.com/eslint/eslint) from 7.17.0 to 7.18.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.17.0...v7.18.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Remove axios vulnerability (#703) Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Lazy index getting started suggestion (#571) * Prepare documentation for release 11/2020 of MeiliSearch * Change documents references * Add lazy index to indexes main concept * Suggestion for lazy index into getting started * Fix type * Apply suggestions from code review Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update guides/introduction/quick_start_guide.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update .vuepress/config.js Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update references/documents.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Remove create index code sample * Update guides/introduction/quick_start_guide.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update guides/main_concepts/indexes.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update guides/main_concepts/indexes.md Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update documents addition in getting started. Updated primary key definition * Update .vuepress/components/glossary.vue Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update guides/introduction/quick_start_guide.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Fix styling Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * Update LICENSE (#709) * Update guides/advanced_guides/installation.md Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> * Update upgrading guide in installation Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Tommy <68053732+react-learner@users.noreply.github.com> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axios vulnerability
Oke! So this was a tricky one.
Problem analysiss
axiosis used bymeilisearch< v0.14docs-searchbar.jsusesmeilisearch.vuepress-plugin-meilisearchuses docs-searchbar.js. It uses the last version of docs-searchbar.jsv1.1.10. Which uses meilisearchv0.17.0which do NOT useaxios.So the 1 million question. Why with the latest version of
vuepress-plugin-meilisearchdo we still haveaxiosas a dependency of dependencies?What is going on in yarn.lock
Because the version of docs-searchbar that changed from meilisearch v0.12 to v0.14 was a patch change
1.1.7>1.1.8, and because we are giving as information^1.1, yarn.lock of documentation had no need to update the dependency.Solution
I removed and re-installed
vuepress-plugin-meilisearchso that it would download the latests version of all dependency.This made the yarn.lock change to the following: